Add new architecture support for iOS, Android with Windows update #852
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes update add new architecture support and preserved legacy architecture support for iOS and Android, and align implementation with legacy architecture in Windows.
While our team has been recently upgrading an app built with React Native Windows, we notice that we are failed to build under Windows with latest version. We have referenced a few outstanding PRs and aggregate changes from #732 with latest 1.5.9 release, and align the method name across iOS, Android and Windows.
The changes has been verified with a blank app of React Native 0.79.6, bundled in Example folder.
While we have tested the app with above scenario, we believe there are still scenario missed in testing. Please feel free to report further issue found in this PR.
The changes in this PR has been also published to npm as a forked scoped package
@pasteltech/react-native-config
at version1.6.0-rc.0
for sorely testing purpose. We hope this PR could merge into main branch and release ofreact-native-config
and resolve some issues facing by the community.