Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert test main script in algorithm_utils to unit test #3864

Conversation

dennisrall
Copy link
Contributor

There was a main script in the algorithm_utils file for testing. I removed it and created a unit test for it.

Copy link

github-actions bot commented Jan 8, 2024

Unit Test Results

  6 files  ±0    6 suites  ±0   13m 38s ⏱️ -30s
12 tests ±0    7 ✔️  -   2    5 💤 +  2  0 ±0 
60 runs  ±0  30 ✔️  - 12  30 💤 +12  0 ±0 

Results for commit 0c7511a. ± Comparison against base commit 9621757.

This pull request skips 2 tests.
tests.regression_tests.benchmark.test_model_performance ‑ test_performance[ames_housing.gbm.yaml]
tests.regression_tests.benchmark.test_model_performance ‑ test_performance[mercedes_benz_greener.gbm.yaml]

Copy link
Contributor

@arnavgarg1 arnavgarg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dennisrall Thanks for this PR and great catch once again!

@arnavgarg1 arnavgarg1 merged commit e55ad26 into ludwig-ai:master Jan 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants