Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template #1084

Merged
merged 7 commits into from
Jan 5, 2024
Merged

Update PR template #1084

merged 7 commits into from
Jan 5, 2024

Conversation

michplunkett
Copy link
Collaborator

Description of Changes

Updated the PR template so that the title-casing is clear and got rid of a redundant comment.

Tests and linting

  • This branch is up-to-date with the develop branch.
  • pytest passes on my local development environment.
  • pre-commit passes on my local development environment.

@michplunkett michplunkett self-assigned this Jan 4, 2024
Comment on lines -13 to +16
<!-- LINK YOUR ISSUE HERE -->

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is fairly redundant.

@@ -21,7 +24,7 @@ If this pull request is not ready for review yet, please submit it as a draft.
## Screenshots (if appropriate)


## Tests and linting
## Tests and Linting
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the casing of the header to match the other headers.

Copy link
Member

@b-meson b-meson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great.

@michplunkett michplunkett merged commit 076129a into develop Jan 5, 2024
3 checks passed
@michplunkett michplunkett deleted the modify_templates branch January 5, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants