Add create and last_update columns to models #1032
Conversation
...sight/migrations/versions/2023-08-21-0300_a35aa1a114fa_add_create_and_last_update_columns.py
Outdated
Show resolved
Hide resolved
sea-kelp
force-pushed
the
1008/add-create-last-update-columns
branch
from
645c8cd
to
7431f24
Compare
| ) | ||
| batch_op.add_column(sa.Column("last_updated_by", sa.Integer(), nullable=True)) | ||
| batch_op.create_foreign_key( | ||
| "fk_assignments_last_updated_by_users", |
There was a problem hiding this comment.
LAST THING! We have a lot of scenarios where there weren't names used for FKs and they are being input as [table]_[column_name]_fkey. Could you update the foreign key names to that motif?
There was a problem hiding this comment.
I'm addressing all of the previous migrations in this PR: #1036
There was a problem hiding this comment.
Good callout! I've updated the foreign key names
| if hasattr(obj, "last_updated_by") and hasattr(form, "last_updated_by"): | ||
| form.last_updated_by.data = current_user.get_id() | ||
| form.last_updated_at.data = datetime.datetime.now() |
There was a problem hiding this comment.
I think it would make sense to keep this here. That way we are updating the two columns for every edit.
if hasattr(obj, "last_updated_by"):
form.last_updated_by.data = current_user.get_id()
form.last_updated_at.data = datetime.datetime.now()There was a problem hiding this comment.
I've replaced this with the change in populate_obj which will update the last_updated_by and last_updated_at when editing objects
| if hasattr(new_obj, "created_by"): | ||
| new_obj.created_by = current_user.get_id() | ||
| if hasattr(new_obj, "last_updated_by"): | ||
| new_obj.last_updated_by = current_user.get_id() |
There was a problem hiding this comment.
The created_by and last_updated_by for new objects are updated here
| if hasattr(obj, "last_updated_by") and hasattr(form, "last_updated_by"): | ||
| form.last_updated_by.data = current_user.get_id() | ||
| form.last_updated_at.data = datetime.datetime.now() |
There was a problem hiding this comment.
I've replaced this with the change in populate_obj which will update the last_updated_by and last_updated_at when editing objects
| ) | ||
| batch_op.add_column(sa.Column("last_updated_by", sa.Integer(), nullable=True)) | ||
| batch_op.create_foreign_key( | ||
| "fk_assignments_last_updated_by_users", |
There was a problem hiding this comment.
Good callout! I've updated the foreign key names
Add creation and last update columns to track when and by whom models were updated. Run alembic migration N/A - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
Add creation and last update columns to track when and by whom models were updated. Run alembic migration N/A - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
Add creation and last update columns to track when and by whom models were updated. Run alembic migration N/A - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
Add creation and last update columns to track when and by whom models were updated. Run alembic migration N/A - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
Fixes issue
#1008
Description of Changes
Add creation and last update columns to track when and by whom models were updated.
Notes for Deployment
Run alembic migration
Screenshots (if appropriate)
N/A
Tests and linting
developbranch.pytestpasses on my local development environment.pre-commitpasses on my local development environment.