Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send an email when a user updates their password #947

Closed
michplunkett opened this issue Jun 29, 2023 · 0 comments · Fixed by #971
Closed

Send an email when a user updates their password #947

michplunkett opened this issue Jun 29, 2023 · 0 comments · Fixed by #971
Assignees
@michplunkett
Labels
security

Comments

@michplunkett
Copy link
Collaborator

What issue are you seeing?

Currently, if updates their password in the application outside of the flow of "forgetting their password" they are notified via an email. This is leaves open the possibility that someone's password gets leaked, their password gets changed, and they aren't made aware.
@michplunkett michplunkett self-assigned this Jun 29, 2023
@michplunkett michplunkett changed the title We should send an email when someone has updated their password Send an email when a user updates their password Jun 29, 2023
@michplunkett michplunkett mentioned this issue Jul 13, 2023
Merged
3 tasks
@michplunkett michplunkett linked a pull request Jul 13, 2023 that will close this issue
Add password change confirmation email #971
Merged
3 tasks
michplunkett added a commit that referenced this issue Jul 17, 2023
@michplunkett
Add password change confirmation email (#971)
3606e67 
## Fixes issue
#947

## Description of Changes
Added an email action that lets the user know that their password has
changed and added validation that emails were being sent in the tests.

## Notes for Deployment
- The `OO_ADMIN_EMAIL` environment variable needs to be added to the
production `.env` file.

## Screenshots (if appropriate)
<img width="1074" alt="Screenshot 2023-07-13 at 1 44 06 PM"
src="https://github.com/lucyparsons/OpenOversight/assets/5885605/1d0195db-b8fb-4e96-8f20-945a8b0633e7">

## Tests and linting
 - [x] This branch is up-to-date with the `develop` branch.
 - [x] `pytest` passes on my local development environment.
 - [x] `pre-commit` passes on my local development environment.
sea-kelp pushed a commit to OrcaCollective/OpenOversight that referenced this issue Sep 6, 2023
@michplunkett @sea-kelp
Add password change confirmation email (lucyparsons#971)
5744985 
lucyparsons#947

Added an email action that lets the user know that their password has
changed and added validation that emails were being sent in the tests.

- The `OO_ADMIN_EMAIL` environment variable needs to be added to the
production `.env` file.

<img width="1074" alt="Screenshot 2023-07-13 at 1 44 06 PM"
src="https://github.com/lucyparsons/OpenOversight/assets/5885605/1d0195db-b8fb-4e96-8f20-945a8b0633e7">

 - [x] This branch is up-to-date with the `develop` branch.
 - [x] `pytest` passes on my local development environment.
 - [x] `pre-commit` passes on my local development environment.
sea-kelp pushed a commit to OrcaCollective/OpenOversight that referenced this issue Sep 25, 2023
@michplunkett @sea-kelp
Add password change confirmation email (lucyparsons#971)
7f9829f 
lucyparsons#947

Added an email action that lets the user know that their password has
changed and added validation that emails were being sent in the tests.

- The `OO_ADMIN_EMAIL` environment variable needs to be added to the
production `.env` file.

<img width="1074" alt="Screenshot 2023-07-13 at 1 44 06 PM"
src="https://github.com/lucyparsons/OpenOversight/assets/5885605/1d0195db-b8fb-4e96-8f20-945a8b0633e7">

 - [x] This branch is up-to-date with the `develop` branch.
 - [x] `pytest` passes on my local development environment.
 - [x] `pre-commit` passes on my local development environment.
sea-kelp pushed a commit to OrcaCollective/OpenOversight that referenced this issue Oct 5, 2023
@michplunkett @sea-kelp
Add password change confirmation email (lucyparsons#971)
08ee32c 
lucyparsons#947

Added an email action that lets the user know that their password has
changed and added validation that emails were being sent in the tests.

- The `OO_ADMIN_EMAIL` environment variable needs to be added to the
production `.env` file.

<img width="1074" alt="Screenshot 2023-07-13 at 1 44 06 PM"
src="https://github.com/lucyparsons/OpenOversight/assets/5885605/1d0195db-b8fb-4e96-8f20-945a8b0633e7">

 - [x] This branch is up-to-date with the `develop` branch.
 - [x] `pytest` passes on my local development environment.
 - [x] `pre-commit` passes on my local development environment.
AetherUnbound pushed a commit to OrcaCollective/OpenOversight that referenced this issue Oct 9, 2023
@michplunkett @AetherUnbound
Add password change confirmation email (lucyparsons#971)
a72466c 
lucyparsons#947

Added an email action that lets the user know that their password has
changed and added validation that emails were being sent in the tests.

- The `OO_ADMIN_EMAIL` environment variable needs to be added to the
production `.env` file.

<img width="1074" alt="Screenshot 2023-07-13 at 1 44 06 PM"
src="https://github.com/lucyparsons/OpenOversight/assets/5885605/1d0195db-b8fb-4e96-8f20-945a8b0633e7">

 - [x] This branch is up-to-date with the `develop` branch.
 - [x] `pytest` passes on my local development environment.
 - [x] `pre-commit` passes on my local development environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michplunkett michplunkett

Labels
security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add password change confirmation email lucyparsons/OpenOversight
1 participant
@michplunkett