Revert and cleanup the verify_connection task (#995)

* Revert and cleanup the verify_connection task to fix random race conditions. Fxies #902

* oops. I was doing testing and forgot to remove this variable assignment

spec/avram/tasks/db_verify_connection_spec.cr

@@ -1,6 +1,13 @@
 require "../../spec_helper"
 
 describe Db::VerifyConnection do
+  it "runs a test connection" do
+    task = Db::VerifyConnection.new
+    task.output = IO::Memory.new
+    task.run_task
+    task.output.to_s.should contain "Connection verified"
+  end
+
   it "throws a helpful error" do
     creds = Avram::Credentials.parse("postgres://eat@joes/crab_shack")
     TestDatabase.temp_config(credentials: creds) do

spec/spec_helper.cr

@@ -23,7 +23,6 @@ Avram.initialize_logging
 
 Db::Create.new(quiet: true).run_task
 Db::Migrate.new(quiet: true).run_task
-Db::VerifyConnection.new(quiet: true).run_task
 
 Avram::SpecHelper.use_transactional_specs(TestDatabase)
 

src/avram/tasks/db/verify_connection.cr

@@ -18,9 +18,12 @@ class Db::VerifyConnection < BaseTask
   end
 
   def run_task
-    Avram.settings.database_to_migrate.verify_connection
-    puts "✔ Connection verified" unless quiet?
-  rescue Avram::ConnectionError
+    # Using this block method instead of the previous `Database.verify_connection`
+    # due to some random race conditions that cause this task to fail for some people
+    DB.open(Avram.settings.database_to_migrate.settings.credentials.url) do |_db|
+      output.puts "✔ Connection verified" unless quiet?
+    end
+  rescue Avram::ConnectionError | DB::ConnectionRefused
     raise <<-ERROR
     Unable to connect to Postgres for database '#{Avram.settings.database_to_migrate}'.