Skip to content

Commit

Permalink
fix helm
Browse files Browse the repository at this point in the history
  • Loading branch information
Eugenio Marzo committed Sep 11, 2024
1 parent 7074222 commit 5c78342
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 9 deletions.
7 changes: 2 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -198,13 +198,10 @@ helm repo update
kubectl create namespace kubeinvaders

# With ingress and TLS enabled
helm install kubeinvaders --set-string config.target_namespace="namespace1\,namespace2" \
-n kubeinvaders kubeinvaders/kubeinvaders --set ingress.enabled=true --set ingress.hostName=kubeinvaders.io --set deployment.image.tag=latest
helm install --set-string config.target_namespace="namespace1\,namespace2" --set ingress.enabled=true --set ingress.hostName=kubeinvaders.soukubedev.corp.sourcesense.com --set deployment.image.tag=latest -n kubeinvaders mychaoslab kubeinvaders/kubeinvaders --set ingress.tls_enabled=true

# With ingress enabled but TLS disabled (in case you have a reverse-proxy that does TLS termination and nginx controller in http)

helm install kubeinvaders --set-string config.target_namespace="namespace1\,namespace2" \
-n kubeinvaders kubeinvaders/kubeinvaders --set ingress.enabled=true --set ingress.tls_enabled=false --set ingress.hostName=kubeinvaders.io --set deployment.image.tag=latest
helm install --set-string config.target_namespace="namespace1\,namespace2" --set ingress.enabled=true --set ingress.hostName=kubeinvaders.soukubedev.corp.sourcesense.com --set deployment.image.tag=latest -n kubeinvaders mychaoslab kubeinvaders/kubeinvaders/ --set ingress.tls_enabled=false

```

Expand Down
2 changes: 1 addition & 1 deletion helm-charts/kubeinvaders/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ metadata:
{{- end }}
spec:
ingressClassName: {{ .Values.ingress.className }}
{{- if .Values.ingress.tls_enabled }}
tls:
{{- if .Values.ingress.tls_enabled -}}
- hosts:
- {{ .Values.ingress.hostName | quote }}
secretName: {{ .Values.ingress.secretName }}
Expand Down
4 changes: 1 addition & 3 deletions helm-charts/kubeinvaders/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,9 @@ ingress:
enabled: false
legacyIngress: false
className: "nginx"
annotations:
nginx.ingress.kubernetes.io/ssl-redirect: "true"
annotations: {}
hostName: ""
tls: {}
tls_enabled: true

# Use route_host only if ingress is disabled - please specify also the port like route_host: "kubeinvaders.example.com:8080"
# The port must be the same of the NodePort service
Expand Down

0 comments on commit 5c78342

Please sign in to comment.