-
-
Notifications
You must be signed in to change notification settings - Fork 179
Description
Description
Sporadically every now and then, a spark report fails to upload and thus immediately saves the report to disk instead. This seems to rarely occur on a wide range of devices, game and mod versions, operating systems, network/firewall setups (or lack of them). When trying a report upload immediately after, it succeeds as normal.
Proposed Behaviour
So this is not to try to diagnose such sporadic issues, rather, I'd like to request a functionality to auto retry the upload just at least one time if it fails, before resorting to saving the report on disk instead. For example, I see in handleUpload that on upload if an exception occurs, it immediately switches to saveToFile = true; and proceeds with the disk save procedure - in this place, it'd be great if the first time this occurred, it'd loop back to trying the upload once more, and if that fails (or after however many intended retries there's to be given), only then to resort to saving to disk.
This'd help a lot with sometimes for example users supplying a spark profile file instead of a (much more convenient) report URL to diagnose performance issues, as it turns out that one upload just happened to fail (but their subsequent or even previous tries worked fine). Once such a report is in a local file format, it'll need to be passed around as a file upload for people to upload to view locally which is a lot more cumbersome, so if it could've succeeded from a retried upload that'd have been great.
Extra Details
No response