make rules scala compatible with bazelbsp #57
Conversation
ryan28561
force-pushed
the
rules-scala-fixup
branch
from
bb1aea9
to
103c194
Compare
| use_ijar = ctx.attr.use_ijar, | ||
| version = ctx.attr.version, | ||
| ) | ||
| return struct( |
There was a problem hiding this comment.
This is a step backwards. Why are we doing this?
Old implementation functions can also be written in a legacy style where the implementation function returns a struct instead of list of provider objects. This style is strongly discouraged and rules should be migrated away from it.
There was a problem hiding this comment.
Huh, so I don't want to speak for Jaden, who actually knows what he's doing, but I seem to recall him saying that we needed it so we could get access to it from the aspect in bazel-bsp/hirschgarten. I did just update it to use ["_ScalaConfiguration"] instead of .scala_configuration though, and afaict, it seems to work exactly the same.
There was a problem hiding this comment.
Ah ok, I think I fixed it so we won't need this. JetBrains/hirschgarten@7077bff
@jadenPete actually wrote all of this, it just adds compiler information to the bazel providers(? or something, I don't know bazel that well) so bazelbsp can use it.