Removed sageconv dropout due to not existing anymore(?) #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh thanks Marcus! edit: want to bump the patch version while you are at it? |
lucidrains
reviewed
Mar 14, 2024
meshgpt_pytorch/meshgpt_pytorch.py
Outdated
| # initial sage conv | ||
|
|
||
| sageconv_kwargs = {**sageconv_kwargs, 'sageconv_dropout' : sageconv_dropout} | ||
| sageconv_kwargs = {**sageconv_kwargs} |
There was a problem hiding this comment.
you can just remove this line altogether
There was a problem hiding this comment.
you can just remove this line altogether
All done :) I also bumped the version
lucidrains
reviewed
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like the torch_geometric dropped or change the args for SAGEConv so sageconv_dropout is no longer a valid arg.
@lucidrains Please approve this pull request since you are not able to create the autoencoder without removing this arg.
I've seen no improvements in accuracy when using the dropout so it probably isn't needed or very useful.
Thank you 😄