Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#6] make loss positive #7

Merged
merged 1 commit into from
Jun 24, 2020
Merged

[#6] make loss positive #7

merged 1 commit into from
Jun 24, 2020

Conversation

NaxAlpha
Copy link
Contributor

Although it does not matter but adding 2 to loss function makes it positive and it converges to 0 rather than -2 and it is also mentioned in the paper:

image

lucidrains
lucidrains approved these changes Jun 24, 2020
View reviewed changes
Copy link
Owner

@lucidrains lucidrains left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea! i think it's confusing everyone lol

@lucidrains lucidrains merged commit 7126694 into lucidrains:master Jun 24, 2020
@lucidrains lucidrains mentioned this pull request Jun 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucidrains lucidrains lucidrains approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NaxAlpha @lucidrains