Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added square-round-corner icon #2323

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

liamb13
Copy link

@liamb13 liamb13 commented Jul 21, 2024

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Adds a border-radius icon.

Icon use case

This adds a visual representation for border-radius.
Could be useful in a design application to represent corners.
Could also be used as a visual guide for different button properties, e.g; a square or rounded one might use this to indicate what's changing.

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons: box-select and maximize with some subtle tweaks to better suit this icon.
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case: Alternative name consider was corner-radius, which arguably is a better suit for it's name. But I think if someone were looking for this icon, their search would be border-radius.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jul 21, 2024
Copy link

github-actions bot commented Jul 21, 2024

Added or changed icons

icons/square-round-corner.svg

Preview cohesion icons/square-arrow-down-left.svg
icons/square-round-corner.svg
icons/cable.svg
Preview stroke widths icons/square-round-corner.svg
icons/square-round-corner.svg
icons/square-round-corner.svg
DPI Preview (24px) icons/square-round-corner.svg
Icon X-rays icons/square-round-corner.svg
Icon Diffs icons/square-round-corner.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const SquareRoundCornerIcon = createLucideIcon('SquareRoundCorner', [
  ["path",{"d":"M21 11a8 8 0 0 0-8-8"}],
  ["path",{"d":"M21 15v4a2 2 0 0 1-2 2H5a2 2 0 0 1-2-2V5a2 2 0 0 1 2-2h4"}]
])

@jguddas
Copy link
Member

jguddas commented Jul 21, 2024

What about using box-select as a base?

icons
Open lucide studio

@liamb13
Copy link
Author

liamb13 commented Jul 21, 2024

What about using box-select as a base?

iconsOpen lucide studio

I did experiment with a similar design, however, I thought the rounded corners surrounding it (top-left, bottom-left, bottom-right) be a little confusing. Does it imply a different radius for just the 1 corner.
image

@liamb13
Copy link
Author

liamb13 commented Jul 21, 2024

A slight variation that combines the two:
icons
Open lucide studio

@liamb13
Copy link
Author

liamb13 commented Jul 21, 2024

Another option might be to base it on spline:
icons
Open lucide studio

@jguddas
Copy link
Member

jguddas commented Jul 21, 2024

Another option might be to base it on spline:
icons
Open lucide studio

That doesn't look like a corner to me.

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Aug 21, 2024
@jguddas
Copy link
Member

jguddas commented Nov 9, 2024

Maybe even better?
icons
Open lucide studio

@jguddas jguddas changed the title feat(icons): added border-radius icon feat(icons): added square-round-corner icon Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants