-
-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icon-component): Creating icons with iconNodes #1997
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-icon-component
…e-icon-component
…cide into use-icon-component
…e-icon-component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🅰️ angular package
About the Angular package
📦 dependencies
Pull requests that update a dependency file
📖 documentation
Improvements or additions to documentation
🧳 lucide package
About the lucide package
🚀 Lucide v1
⚛️ preact package
About the Preact Package
⚛️ react native package
About the React Native package
⚛️ react package
Lucide React Package
🌍 site
Has to do something with the Lucide website
🪝 solid package
About the Solid package
🧣 svelte package
About the Svelte package
💎 vue package
Lucide Vue package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributes to #1687
What is the purpose of this pull request?
Todo
Description
Implementation of the
<Icon />
component for remaining packages which makes it easier to create (custom) icons from iconNodes.This will be useful for future packages we want to launch like
@lucide/lab
and more.Icon component
This is to create an icon with an iconNode.
Example