Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add trending-flat icon #1662

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jonas-hoebenreich
Copy link
Contributor

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

The 'trending-flat' icon depicts a wavy line, symbolizing a neutral or stable trend with minor fluctuations, ideal for representing periods of minimal change in financial or market data.
image

Icon use case

The icon can be used in financial reports and dashboards to represent periods of stability or minimal changes in stock prices, economic indicators, or market trends. It can also be utilized in data visualization to indicate a neutral or flat trend in graphs and charts.

Alternative icon designs

image

Icon Design Checklist

Concept

  • I have provided valid use cases for the icon.
  • I have not added any brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icon is solely my own creation.
  • The icon was originally created in # by @
  • I've based it on the following Lucide icons: move-right
  • I've based it on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named the icon by what it is rather than its use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icon looks sharp on low DPI displays.
  • I've made sure that the icon looks consistent with the icon set in size, optical volume, and density.
  • I've made sure that the icon is visually centered.
  • I've correctly optimized the icon to two points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Nov 5, 2023
Copy link

github-actions bot commented Nov 5, 2023

Added or changed icons

icons/trending-flat.svg

Preview cohesion icons/square-pilcrow.svg
icons/trending-flat.svg
icons/tornado.svg
Preview stroke widths icons/trending-flat.svg
icons/trending-flat.svg
icons/trending-flat.svg
DPI Preview (24px) icons/trending-flat.svg
Icon X-rays icons/trending-flat.svg
Icon Diffs icons/trending-flat.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const TrendingFlatIcon = createLucideIcon('TrendingFlat', [
  ["path",{"d":"m2 12 1.651-.99A4.56 4.56 0 0 1 9.5 12v0a4.56 4.56 0 0 0 5.849.99l.43-.257A5.136 5.136 0 0 1 18.425 12H22"}],
  ["path",{"d":"m18 8 4 4-4 4"}]
])

Comment on lines +12 to +13
<path
d="m2 12 1.651-.99A4.56 4.56 0 0 1 9.5 12v0a4.56 4.56 0 0 0 5.849.99l.43-.257A5.136 5.136 0 0 1 18.425 12H22" />
Copy link
Member

@jguddas jguddas Nov 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tail feels top-heavy.

Based on wave icon - 2023-11-05T190744 857, not really happy with it either tho.

Suggested change
<path
d="m2 12 1.651-.99A4.56 4.56 0 0 1 9.5 12v0a4.56 4.56 0 0 0 5.849.99l.43-.257A5.136 5.136 0 0 1 18.425 12H22" />
<path d="M2 12c.6.5 1.2 1 2.5 1 2.5 0 2.5-2 5-2 2.6 0 2.4 2 5 2 2.5 0 2.5-2 7.5-1" />

@karsa-mistmere
Copy link
Member

I was just about to suggest using move-right for this use case, which actually has trend flat as a tag, but surely you must be aware of this, @jonas-hoebenreich, since move-right was also submitted by you. 😄

Still, I do personally think, move-right fits better with trending-up and trending-down than a wavy line would:
image

@ericfennis
Copy link
Member

Good point @karsa-mistmere !
@jonas-hoebenreich Can move-right fit this usecase or can you explain why not?

@jonas-hoebenreich
Copy link
Contributor Author

Well, a wavy arrow can be used to symbolize that something does not run in a straight line. However, if you only have straight arrows, this aspect is eliminated.

@ericfennis
Copy link
Member

@jonas-hoebenreich Good point. I'm fine with adding this kind of icon.
But I understand @karsa-mistmere doubts about the design. It's not matching the other trending icons very well. Maybe we can try to make some alternatives?

@karsa-mistmere
Copy link
Member

How about a more rectangular approach to better match the style of current trending icons?

image

In either case, should we add this icon, I think it should be named arrow-right-wavy or something similar in line with our icon naming guidelines.

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants