Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added pointer-off icon #1567

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Sep 18, 2023

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Icon use case

To mark something as non interactive. "you can't touch this"

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons: pointer
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to two points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Sep 18, 2023
@jguddas jguddas force-pushed the feat/added-pointer-off-icon branch from 1d0d156 to fa2108a Compare September 18, 2023 16:46
@github-actions
Copy link

github-actions bot commented Sep 18, 2023

Added or changed icons

icons/pointer-off.svg

Preview cohesion icons/arrow-left-square.svg
icons/pointer-off.svg
icons/droplets.svg
Preview stroke widths icons/pointer-off.svg
icons/pointer-off.svg
icons/pointer-off.svg
DPI Preview (24px) icons/pointer-off.svg
Icon X-rays icons/pointer-off.svg

@jguddas jguddas force-pushed the feat/added-pointer-off-icon branch from fa2108a to 5264ae1 Compare September 18, 2023 16:50
@jguddas
Copy link
Member Author

jguddas commented Sep 18, 2023

icons/pointer-off.svg

@karsa-mistmere
Copy link
Member

karsa-mistmere commented Oct 6, 2023

Do you think we can try one where the slash is flipped horizontally?
While almost all of our -off icons use this slash, for phone-off, a reflected slash also proved to be better.

image

Edit: made one, and it (also) looks a bit meh (kinda like 🖕 actually, dunno why):

image

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Nov 10, 2023
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericfennis ericfennis merged commit ab59a1e into lucide-icons:main Dec 15, 2023
realguse pushed a commit to realguse/lucide that referenced this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants