Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fire/safety/security/amenities icons #1392

Merged
merged 26 commits into from
Dec 16, 2023
Merged

Add fire/safety/security/amenities icons #1392

merged 26 commits into from
Dec 16, 2023

Conversation

danielbayley
Copy link
Member

@danielbayley danielbayley commented Jun 24, 2023 •
edited
Loading

alarm-smoke alts:

preview

@github-actions github-actions bot added 🌍 site Has to do something with the Lucide website 🎨 icon About new icons 🫧 metadata Improved metadata labels Jun 24, 2023
@github-actions
Copy link

github-actions bot commented Jun 24, 2023 •
edited
Loading

Added or changed icons


Preview cohesion icons/messages-square.svg icons/play-square.svg icons/x-square.svg icons/power-square.svg

icons/file-up.svg icons/message-circle-off.svg icons/scroll-text.svg icons/indent.svg
Preview stroke widths


DPI Preview (24px)
Icon X-rays

@github-actions github-actions bot removed the 🌍 site Has to do something with the Lucide website label Jun 28, 2023
@danielbayley danielbayley changed the title Add fire-extinguisher/smoke-alarm amenities icons/improve metadata Add smoke/fire-[extinguisher/alarm] amenities icons/improve metadata Jun 28, 2023
@ericfennis
Copy link
Member

Nice icons, I'm not sure about the smoke alarm. For me, it was not directly recognizable as one.

@danielbayley danielbayley changed the title Add smoke/fire-[extinguisher/alarm] amenities icons/improve metadata Add fire/safety/security/amenities icons Jul 22, 2023
karsa-mistmere
karsa-mistmere reviewed Jul 24, 2023
View reviewed changes
icons/fire-alarm.svg Outdated Show resolved Hide resolved
icons/fire-alarm.json Outdated Show resolved Hide resolved
icons/fire-alarm.json Outdated Show resolved Hide resolved
@karsa-mistmere karsa-mistmere mentioned this pull request Jul 24, 2023
Merged
danielbayley and others added 2 commits July 24, 2023 09:53
@danielbayley @karsa-mistmere
Update icons/fire-alarm.json
2fcd56a 
Co-authored-by: Karsa <contact@karsa.org>
@danielbayley @karsa-mistmere
Update icons/fire-alarm.json
aede0ca 
Co-authored-by: Karsa <contact@karsa.org>
@jguddas
Copy link
Member

jguddas commented Jul 24, 2023

The camera body and circle are not connected, there is a small gap.

@jguddas
Copy link
Member

jguddas commented Jul 24, 2023

This blue element should be an arc, but no big deal.

@jguddas
Copy link
Member

jguddas commented Jul 24, 2023

This blue element should be an arc, but no big deal.

@jguddas Tricky to do these manually… but fixed anyway!

I need to work on the arc fitting algorithm so we can automate this.

@ericfennis
Copy link
Member

@danielbayley No I think the icon design is taken too literally as a "smoke alarm" device. And this is not very good at telling the message that it is a smoke alarm. It can also be seen as a random device like a wifi access point.

I think we should have something with "smoke", to tell the message more that it is a smoke alarm.
Like material icons:
image

ericfennis
ericfennis reviewed Jul 24, 2023
View reviewed changes
icons/cctv.svg
@@ -0,0 +1,16 @@
<svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, the icon is a bit too detailed, especially the camera lens part. If you compare it with like the camera or video icons. I think should be nice if they match.

Here some inspiration of CCTV icons that are more simplified

image
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericfennis See latest push, and/or these alts:

preview

cc: @karsa-mistmere @jguddas

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm for the last one. It's simple and friendly. The other ones looks a bit "evil" in don't know 😅
And it matches a bit with the other video icon

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks a bit "evil"

I think CCTV cameras are supposed to seem a bit sinister 😅

I really like the first one best. But I suppose it comes down to another vote (need something like this bot again)…

@danielbayley
Copy link
Member Author

danielbayley commented Jul 26, 2023 •
edited
Loading

this is not very good at telling the message that it is a smoke alarm. It can also be seen as a random device like a wifi access point.

I was going off this one I came across in the wild, on some travel site… I don’t recall exactly which.

Untitled

@ericfennis Anyway resolved now…

@danielbayley danielbayley requested a review from ericfennis July 27, 2023 01:09
@ericfennis
Copy link
Member

@danielbayley Nicely done!

@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Aug 27, 2023
karsa-mistmere
karsa-mistmere previously requested changes Aug 28, 2023
View reviewed changes
icons/alarm-smoke.svg Outdated Show resolved Hide resolved
icons/cctv.svg Outdated Show resolved Hide resolved
icons/fire-extinguisher.svg Outdated Show resolved Hide resolved
ericfennis and others added 3 commits December 15, 2023 15:10
@ericfennis @karsa-mistmere
Update icons/alarm-smoke.svg
dd20023 
Co-authored-by: Karsa <contact@karsa.org>
@ericfennis @karsa-mistmere
Update icons/cctv.svg
f14d5fb 
Co-authored-by: Karsa <contact@karsa.org>
@ericfennis @karsa-mistmere
Update icons/fire-extinguisher.svg
1928109 
Co-authored-by: Karsa <contact@karsa.org>
@ericfennis ericfennis merged commit df58c3f into lucide-icons:main Dec 16, 2023
5 of 6 checks passed
realguse pushed a commit to realguse/lucide that referenced this pull request Dec 25, 2024
@danielbayley @karsa-mistmere @ericfennis
Add fire/safety/security/amenities icons (lucide-icons#1392)
c04685f 
* Add `fire-extinguisher` icon

* Add `smoke-alarm` icon

* Improve fire related metadata

* Add `fire-alarm` icon

* Add `cctv` icon

* Add `cctv-off` icon

* Update icons/fire-alarm.json

Co-authored-by: Karsa <contact@karsa.org>

* Update icons/fire-alarm.json

Co-authored-by: Karsa <contact@karsa.org>

* Rename `fire-alarm` to `bell-alarm`

* Refine `cctv` icons

* Optimise `bell-alarm` icon

* Rename `bell-alarm` to `bell-electric`

* Rename `smoke-alarm` to `alarm-smoke`

* Refine `alarm-smoke` icon

* Refine `cctv` icons

* Update icons/alarm-smoke.svg

Co-authored-by: Karsa <contact@karsa.org>

* Update icons/cctv.svg

Co-authored-by: Karsa <contact@karsa.org>

* Update icons/fire-extinguisher.svg

Co-authored-by: Karsa <contact@karsa.org>

* update pr workflow

* update pr workflow

* add env

* remove cctv off icons

---------

Co-authored-by: Karsa <contact@karsa.org>
Co-authored-by: Eric Fennis <eric.fennis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karsa-mistmere karsa-mistmere karsa-mistmere left review comments

@ericfennis ericfennis Awaiting requested review from ericfennis

Assignees
No one assigned
Labels
🎨 icon About new icons 🫧 metadata Improved metadata Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielbayley @ericfennis @jguddas @karsa-mistmere