Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TV/controller/connector icons #1341

Merged
merged 22 commits into from
Jul 17, 2023
Merged

Add TV/controller/connector icons #1341

merged 22 commits into from
Jul 17, 2023

Conversation

danielbayley
Copy link
Member

@danielbayley danielbayley commented Jun 5, 2023 •
edited
Loading

triangle-right related to #1142.

Edit: Leaving other cable[-*] icons here, for reference…

preview

@github-actions
Copy link

github-actions bot commented Jun 5, 2023 •
edited
Loading

Added or changed icons

icons/antenna.svg icons/cable.svg icons/hdmi-port.svg icons/ratio.svg icons/triangle-right.svg

Preview cohesion icons/user-square.svg icons/arrow-up-right-square.svg icons/message-square.svg icons/square-dashed-bottom-code.svg icons/arrow-down-right-square.svg
icons/antenna.svg icons/cable.svg icons/hdmi-port.svg icons/ratio.svg icons/triangle-right.svg
icons/whole-word.svg icons/bar-chart-2.svg icons/message-square-dashed.svg icons/activity.svg icons/salad.svg
Preview stroke widths icons/antenna.svg icons/cable.svg icons/hdmi-port.svg icons/ratio.svg icons/triangle-right.svg
icons/antenna.svg icons/cable.svg icons/hdmi-port.svg icons/ratio.svg icons/triangle-right.svg
icons/antenna.svg icons/cable.svg icons/hdmi-port.svg icons/ratio.svg icons/triangle-right.svg
Icon X-rays icons/antenna.svg icons/cable.svg icons/hdmi-port.svg icons/ratio.svg icons/triangle-right.svg

@jguddas
Copy link
Member

jguddas commented Jun 5, 2023

I like the antenna 👍

jguddas
jguddas reviewed Jun 5, 2023
View reviewed changes
icons/antenna.json Outdated Show resolved Hide resolved
@danielbayley danielbayley changed the title Add TV/control icons Add TV/control/connector icons Jun 6, 2023
@danielbayley danielbayley changed the title Add TV/control/connector icons Add TV/control/connector icons Jun 6, 2023
@danielbayley danielbayley changed the title Add TV/control/connector icons Add TV/controller/connector icons Jun 6, 2023
@karsa-mistmere
Copy link
Member

I think the hoop on connector-audio-video has some legibility issues - both because of smaller than ideal gaps and because hooping doesn't translate well to our lines.

I've tried adding some negative space, but it doesn't quite work:
image

This again would benefit tremendously from a "1px gap OK if it's negative space" guideline rule:
image

We could also play around with the hoop shape:
connector-audio-video

@karsa-mistmere
Copy link
Member

HDMI connector works unbelievably well, I'm crying witchcraft.

@danielbayley
Copy link
Member Author

maybe even cable-*

@karsa-mistmere Renamed, and added connector to the metadata instead.

It isn't, it's just something that I wish was. 😆

So this one [cable-audio-video] wouldn’t be accepted in it’s current form? @ericfennis

@danielbayley danielbayley requested a review from jguddas June 6, 2023 20:01
@ericfennis
Copy link
Member

@danielbayley I think it's not really clear what the exact purpose is of the cable-audio-video. I think it's better to keep It more generic. On 100% scale, it is really to distinguish them from each other.

And I'm not sure about renaming de tv-2 to tv-flatscreen. Yes, this is maybe a better name. But we can't really add an alias for this because then we can never add a tv-2 icon in the future. And I think we should be more carefull with renaming things without adding "backward compatibility". I think we should keep it as it is.

jguddas
jguddas reviewed Jun 11, 2023
View reviewed changes
icons/hdmi-port.svg
@@ -0,0 +1,14 @@
<svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels a bit small and is hard to identify as a port.
What about something like this?
icon (87)

icons/hdmi-port.svg Outdated Show resolved Hide resolved
icons/ratio.json Show resolved Hide resolved
icons/triangle-right.json
@@ -0,0 +1,22 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎 don't like it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎 don't like it.

@jguddas Maybe useful to have slightly more constructive feedback than that 😅

Do we not want to cover all base shapes…? Should be part of #1142?

icons/tv-flatscreen.json Outdated Show resolved Hide resolved
icons/tv-flatscreen.json Outdated Show resolved Hide resolved
@jguddas
Copy link
Member

jguddas commented Jun 11, 2023

My comment about the cables got lost, in short, I vote for only keeping the cable-plugs and naming the icon cable.

danielbayley and others added 3 commits June 12, 2023 20:15
@danielbayley @jguddas
Update icons/tv-flatscreen.json
a856391 
Co-authored-by: Jakob Guddas <github@jguddas.de>
@danielbayley @jguddas
Update icons/hdmi-port.svg
1332e57 
Co-authored-by: Jakob Guddas <github@jguddas.de>
@danielbayley @jguddas
Update icons/ratio.json
d2eecbf 
Co-authored-by: Jakob Guddas <github@jguddas.de>
@danielbayley
Copy link
Member Author

not sure about renaming de tv-2 to tv-flatscreen … I think we should keep it as it is.

@ericfennis reverted.

@ericfennis
Copy link
Member

I agree with @jguddas . Maybe one cable icon will fulfill the use-case. On 100% scale it is hard to see if it is a power cable or USB. For example if you want to indicate that something is going on with your power cable I think plug or plug-zap is a better fit for that.

@danielbayley
Copy link
Member Author

I vote for only keeping the cable-plugs and naming the icon cable.

Maybe one cable icon will fulfill the use-case.

@jguddas @ericfennis pushed…

ericfennis
ericfennis approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielbayley Awesome work!

@ericfennis ericfennis merged commit 79eecc8 into lucide-icons:main Jul 17, 2023
@danielbayley danielbayley deleted the controls-tv branch July 17, 2023 18:15
realguse pushed a commit to realguse/lucide that referenced this pull request Dec 25, 2024
@danielbayley @jguddas
Add TV/controller/connector icons (lucide-icons#1341)
d5da9a7 
* Add [aspect] `ratio` icon

* Rename `tv-2` to `tv-flatscreen`

* Add `triangle-right` (volume) icon

* Add `antenna` icon

* Add `connector-audio-video` icon

* Improve metadata

* Add [generic] `connector` icon

* Add `connector-usb` icon

* Improve metadata

* Add `hdmi-port` icon

* Improve metadata

* Add `connector-audio-video` icon

* Improve metadata

* Rename `connector-*` icons to `cable-*`

* Rename `cable` to `cable-plugs`

* Update icons/tv-flatscreen.json

Co-authored-by: Jakob Guddas <github@jguddas.de>

* Update icons/hdmi-port.svg

Co-authored-by: Jakob Guddas <github@jguddas.de>

* Update icons/ratio.json

Co-authored-by: Jakob Guddas <github@jguddas.de>

* Revert "Rename `tv-2` to `tv-flatscreen`"

This reverts commit 7df3555.

* Remove `cable-audio-video` icon

* Rename `cable-plugs` to `cable`

* Remove `cable-usb` icon

---------

Co-authored-by: Jakob Guddas <github@jguddas.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karsa-mistmere karsa-mistmere karsa-mistmere approved these changes

@ericfennis ericfennis ericfennis approved these changes

@jguddas jguddas Awaiting requested review from jguddas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielbayley @jguddas @karsa-mistmere @ericfennis