Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add squircle #1293

Merged
merged 9 commits into from
Dec 15, 2023
Merged

Add squircle #1293

merged 9 commits into from
Dec 15, 2023

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented May 18, 2023 •
edited
Loading

The now so fashionable shape between a square and a circle.

I made it 19px in size, this makes it .5px off grid, which might be a problem.

Use: Icon shape chooser.

image

@vercel
Copy link

vercel bot commented May 18, 2023

@jguddas is attempting to deploy a commit to the Lucide Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

github-actions bot commented May 18, 2023 •
edited
Loading

Added or changed icons

icons/squircle.svg

Preview cohesion icons/arrow-down-left-square.svg
icons/squircle.svg
icons/dumbbell.svg
Preview stroke widths icons/squircle.svg
icons/squircle.svg
icons/squircle.svg
DPI Preview (24px) icons/squircle.svg
Icon X-rays icons/squircle.svg

@karsa-mistmere
Copy link
Member

Yeah, on a high DPI display it looks neat, but it's pretty damn blurry at 1x.

image
image

@github-actions github-actions bot added the Stale label Jun 19, 2023
@jguddas jguddas closed this Jun 19, 2023
@jguddas jguddas reopened this Oct 28, 2023
@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Oct 28, 2023
@vercel
Copy link

vercel bot commented Oct 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lucide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2023 1:31pm

@jguddas
Copy link
Member Author

jguddas commented Oct 28, 2023

We could consider unifying the badge, circle and square, currently we have a bunch of different icons for each shape.

icon - 2023-10-28T154433 964icon - 2023-10-28T154711 419check-square (1)check-circle (1)

ericfennis
ericfennis approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this shape icon.
Looking at the 24px DPI preview it looks fine to me.

@jguddas
Copy link
Member Author

jguddas commented Oct 31, 2023

I'm ok with this shape icon. Looking at the 24px DPI preview it looks fine to me.

I change it so it is the same size as the square, before it was 0.5px bigger.

@ericfennis
Copy link
Member

@jguddas Awesome!
@karsa-mistmere you also ok with this?

@ericfennis ericfennis removed the Stale label Nov 1, 2023
@lucide-icons lucide-icons deleted a comment from github-actions bot Nov 1, 2023
@ericfennis ericfennis merged commit 315c020 into lucide-icons:main Dec 15, 2023
6 checks passed
realguse pushed a commit to realguse/lucide that referenced this pull request Dec 25, 2024
@jguddas @ericfennis
Add squircle (lucide-icons#1293)
d9c3c08 
* Add `squircle`

* Create squircle.json

* Update squircle.svg

* Update icons/squircle.json

* Update squircle.json

* Update squircle.json

---------

Co-authored-by: Eric Fennis <eric.fennis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericfennis ericfennis ericfennis approved these changes

@karsa-mistmere karsa-mistmere Awaiting requested review from karsa-mistmere

Assignees

@karsa-mistmere karsa-mistmere

Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jguddas @karsa-mistmere @ericfennis