Replace System.out and System.err with logging #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also removes an unused local variable
denizt
changed the title
lucav76
reviewed
Feb 24, 2024
| @@ -253,14 +254,14 @@ public static long transferStream(InputStream is, OutputStream os, String echoLa | |||
| while ((read = is.read(buffer, 0, buffer.length)) >= 0) { | |||
| os.write(buffer, 0, read); | |||
| if (echoLabel != null && transferred < 128) | |||
| System.out.println(echoLabel + ": " + new String(buffer, 0, (int) Math.min(read - transferred, 128))); | |||
| logger.log(Level.FINE, echoLabel + ": " + new String(buffer, 0, (int) Math.min(read - transferred, 128))); | |||
There was a problem hiding this comment.
These are not intended as log, please leave the println
Methods suffixed with short no longer log the stack trace. We also bump the level to INFO which is default, unless overriden by a config file. Silent methods now log the exceptions with the stack trace only for FINEST level.
Also add a FINEST level of logging for caught exceptions.
Add it as an extracted method and comment out the call instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These series of commits removes all
System.outandSystem.errfrom the code replacing in withjava.util.logging, except fromexamplesandtestsThere are also some atomic commits that removes dead/unused code.