Explicitly set DB_ constants in loadOnly:true #755
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #753
This updates the
WPLoader
module, and its documentation, to make sure the database used when using the module inloadOnly:true
mode will be the one specified by thedbUrl
or other db configuration parameters.The module will silence redeclarations of the
DB_HOST
,DB_USER
,DB_PASSWORD
andDB_NAME
constants.The module will also set the
WPBROWSER_LOAD_ONLY
env var to either1
or0
depending on the configuration ofloadOnly
totrue
orfalse
respectively.The latter should provide support for more advanced configurations and mitigations when WordPress set ups with stricter checking (e.g. Bedrock) would render the redefinition silencing useless.