Skip to content

Commit

Permalink
bin nix review: separate the review parts
Browse files Browse the repository at this point in the history
Signed-off-by: lucasew <lucas59356@gmail.com>
  • Loading branch information
lucasew committed Jan 2, 2025
1 parent 2ed9b44 commit 3c745f8
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 8 deletions.
10 changes: 2 additions & 8 deletions bin/nix/qreview
Original file line number Diff line number Diff line change
@@ -1,17 +1,11 @@
#!/usr/bin/env bash

PR="$1"; shift

export JOB_LABEL="review #$PR $*"

# -L "$JOB_LABEL" \
ssh whiterun \
ts \
-m \
systemd-run --user --working-directory ~/nixpkgs -P --collect -p KillSignal=SIGINT -p TimeoutStopSec=infinity \
sdw nix review --really pr "$PR" \
--no-shell \
--post-result \
--build-graph nix \
--eval local \
"$@"
-L "$JOB_LABEL" \
sd nix sdreview "$PR" "$@"
20 changes: 20 additions & 0 deletions bin/nix/sdreview
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@

PR="$1"; shift

systemd-run \
--user \
--working-directory ~/nixpkgs \
-P \
--unit "nixpkgs-review-$PR" \
--collect \
-p KillSignal=SIGINT \
-p TimeoutStopSec=infinity \
\
sdw nix review --really \
\
pr "$PR" \
--no-shell \
--post-result \
--build-graph nix \
--eval local \
"$PR" "$@"

0 comments on commit 3c745f8

Please sign in to comment.