Skip to content

Commit

Permalink
chore: remove unnecessary todos
Browse files Browse the repository at this point in the history
  • Loading branch information
lucasctnh committed Apr 7, 2022
1 parent 4fb258c commit a94b64e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
using UnityEngine.InputSystem;
using Random = UnityEngine.Random;

public class PlayerController : MonoBehaviour { // TODO: refactor this ugly mess
public class PlayerController : MonoBehaviour { // TODO: refactor
public static event Action OnInvertedPosition;
public static event Action OnReachedSwapPoint;
public static event Action OnShouldResetCamera;
Expand Down
8 changes: 4 additions & 4 deletions Assets/Scripts/General/Services/GameManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ public void Resume() {
StartCoroutine(TransitionedResume());
}

public void GameOver(Sound.Type gameOverSound = Sound.Type.None) { // TODO: make every UI button function not work when !IsGamePlayable (cuz of fade)
public void GameOver(Sound.Type gameOverSound = Sound.Type.None) {
AudioManager.Instance.PlaySoundOneShot(gameOverSound, 2);

if (!IsGamePlayable) // to avoid GameOver more than once
Expand Down Expand Up @@ -256,7 +256,7 @@ public void SpendCoins(int price) {
}

public void ChangeBGMVolume(float value) {
OnUpdateVolume?.Invoke(1, value); // TODO: refactor
OnUpdateVolume?.Invoke(1, value);
OnUpdateVolume?.Invoke(3, value);
}

Expand Down Expand Up @@ -367,7 +367,7 @@ private IEnumerator WaitScaleDownTransition(Animator animator) {
}

private void InitializeTrackVolumes() {
InitializeTrackVolume(1); // TODO: refactor
InitializeTrackVolume(1);
InitializeTrackVolume(2);
InitializeTrackVolume(3);
}
Expand All @@ -385,7 +385,7 @@ private void AssignSettings(SettingsSaveData data) {
isCurrentlyLowGraphics = data.isLowGraphics;
AssignQuality();

OnUpdateVolume?.Invoke(1, data.bgmVolume); // TODO: refactor
OnUpdateVolume?.Invoke(1, data.bgmVolume);
OnUpdateVolume?.Invoke(2, data.sfxVolume);
OnUpdateVolume?.Invoke(3, data.bgmVolume);
}
Expand Down

0 comments on commit a94b64e

Please sign in to comment.