Support symbols/strings with spaces. #76
Conversation
lib/enumerate_it/base.rb
Outdated
| @@ -116,7 +116,7 @@ def register_enumeration(values_hash) | |||
| end | |||
|
|
|||
| def define_enumeration_constant(name, value) | |||
| const_set name.to_s.tr('-', '_').upcase, value | |||
| const_set name.to_s.tr('-', '_').upcase.delete(' '), value | |||
There was a problem hiding this comment.
hey @Bialogs - how about replacing the space with a _?
I think it'd make more sense, wouldn't it?
Something like:
...to_s.gsub(/[-\s]/, '_')...In your example, it'd become TestEnumerationWithSpaces::SPA_CES instead of TestEnumerationWithSpaces::SPACES.
There was a problem hiding this comment.
Yea that makes sense.
There was a problem hiding this comment.
While converting the space to _ with match /\s/ it also matches a newline. While newline is valid in a symbol, I'm not sure what your thoughts are on supporting this in the gem and wanted to let you know.
It may be out of scope for this pull request. I'm really only needing spaces in my current usage.
Therefore my recommendation is to use /\p{blank}/ match instead of /\s/ so that the same NameError: wrong constant name ... will appear when someone uses a symbol that contains a newline.
|
@lucascaton Hello just wanted to ask for a status update on this. Thanks! |
|
@Bialogs, I've just noticed that you updated your commit. Thanks again for your PR :) |
Closes #75