catch some chat download exceptions

hopefully fixes MrBrax#138
lucas19961 · Apr 27, 2022 · 253f8a8 · 253f8a8
1 parent 1fd4ad3
commit 253f8a8
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 3 deletions.
diff --git a/client-vue/src/views/FilesView.vue b/client-vue/src/views/FilesView.vue
@@ -3,11 +3,13 @@
         <section class="section">
             <div class="section-title"><h1>Clips</h1></div>
             <div class="section-content">
+                WIP
             </div>
         </section>
         <section class="section">
             <div class="section-title"><h1>VODs</h1></div>
             <div class="section-content">
+                WIP
             </div>
         </section>
     </div>

diff --git a/server/src/Controllers/Vod.ts b/server/src/Controllers/Vod.ts
@@ -101,7 +101,17 @@ export async function DownloadChat(req: express.Request, res: express.Response):
         return;
     }
 
-    const success = await vod.downloadChat();
+    let success;
+
+    try {
+        success = await vod.downloadChat();
+    } catch (error) {
+        res.status(500).send({
+            status: "ERROR",
+            message: `Chat download error: ${(error as Error).message}`,
+        });
+        return;
+    }
 
     res.send({
         status: success ? "OK" : "ERROR",

diff --git a/server/src/Core/Automator.ts b/server/src/Core/Automator.ts
@@ -727,7 +727,12 @@ export class Automator {
         // download chat and optionally burn it
         if (this.channel.download_chat && this.vod.twitch_vod_id) {
             Log.logAdvanced(LOGLEVEL.INFO, "automator", `Auto download chat on ${basename}`);
-            this.vod.downloadChat();
+
+            try {
+                await this.vod.downloadChat();
+            } catch (error) {
+                Log.logAdvanced(LOGLEVEL.ERROR, "automator", `Failed to download chat for ${basename}: ${(error as Error).message}`);
+            }
 
             if (this.channel.burn_chat) {
                 Log.logAdvanced(LOGLEVEL.ERROR, "automator", "Automatic chat burning has been disabled until settings have been implemented.");
@@ -1006,7 +1011,7 @@ export class Automator {
 
                 if (data.includes("Writing output to")) {
                     Log.logAdvanced(LOGLEVEL.INFO, "automator", "Writing output");
-                    if (this.vod){ 
+                    if (this.vod) {
                         this.vod.capture_started2 = new Date();
                         this.vod.broadcastUpdate();
                     }