dry the code using traits #38
Conversation
|
You may rename the traits names to "update" and "created" if you are not happy with the current names |
|
The Also you could merge both into a |
|
@imanghafoori1 names look good for now can you kindly make the changes suggested by @ludo237
Thanks for drying up the code 👍 @ludo237 idea of merging them in single Traits looks good but some modules are not using both createdby / updatedby |
|
I can perform much more refactors using my own package if you do not mind an extra composer package dependency in your project. |
| { | ||
| return $this->belongsTo('App\User', 'updated_by'); | ||
| } | ||
| } |
There was a problem hiding this comment.
No newline at the end of file
| { | ||
| return $this->belongsTo('App\User', 'created_by'); | ||
| } | ||
| } |
There was a problem hiding this comment.
No newline at the end of file
|
@imanghafoori1 not for now but will go through http://github.com/imanghafoori1/laravel-widgetize and let you know if plan to use that. |
|
@ajitbohra Added newlines |
No description provided.