Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024.6.1: In multicolor_text mode, added the ability to reset to default color, improved documentation. #238

Merged

Conversation

andrewjswan
Copy link

No description provided.

@andrewjswan andrewjswan force-pushed the 2024.6.1-multicolor_text-mode-improve branch from d0f584b to 4b026b2 Compare June 8, 2024 11:29
@lubeda
Copy link
Owner

lubeda commented Jun 9, 2024

Is there a way to analyze the text and the colors once instead of every draw cycle? This is slowing down everything in the loop.

perhaps with two arrays: filled on_next_screen

one for the string and the other for the RGB color.

Like

text[] ="ABC"
color[] =[(FF,0,0),(0,FF,0),(0,0,FF)]

The A is red, B is green, C is blue,

This opens a lot more possibilities, like giving each character one color or calculated gradients per character etc.

@andrewjswan
Copy link
Author

image

@andrewjswan
Copy link
Author

This opens a lot more possibilities, like giving each character one color or calculated gradients per character etc.

It seems to me that such a solution will consume a lot of memory, and will also increase the delay, because we will need to output letter by letter and set the color each time... But at the same time we will also need to get an array of colors for each letter.

@andrewjswan
Copy link
Author

I thought about the solution for a long time, but I did not find a simple, effective and fast one that would fit into the concept of the current screens.
But we can always try to optimize, improve and change this functionality.

@lubeda
Copy link
Owner

lubeda commented Jun 9, 2024

I will try to add my idea to the queue constructor, this is where this step really belongs to. It will cost some RAM but the timming will cause problems at the long run, with sensors etc.

@andrewjswan
Copy link
Author

This PR adds flexibility to that functionality and a better example in the documentation. If you change the concept, it is better to use these changes as a basis.

@andrewjswan
Copy link
Author

@lubeda Ant news?

@lubeda lubeda merged commit 07bbf5c into lubeda:2024.6.pre Jun 22, 2024
1 check passed
@lubeda
Copy link
Owner

lubeda commented Jun 22, 2024

I still don't like the effects off this feature but the feature it self is nice.

@andrewjswan andrewjswan deleted the 2024.6.1-multicolor_text-mode-improve branch June 24, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants