Add install commands and __init__.py #2
Conversation
There was a problem hiding this comment.
Thanks for your input, it is very appreciated!
I have some comments on the installation of the python script (see below).
And a question to the __init__.py file: Is this really necessary for some reason? If not, I would prefer to remove it to keep this example as minimal as possible (i.e. only including parts that are necessary for getting the Boost Python bindings to work).
CMakeLists.txt
Outdated
| ) | ||
|
|
||
| file(GLOB py_files "scripts/*.py") |
There was a problem hiding this comment.
To keep it minimalist, I would prefer to not use the file command but just use the explicit filename.
CMakeLists.txt
Outdated
| ) | ||
|
|
||
| file(GLOB py_files "scripts/*.py") | ||
| install(PROGRAMS ${py_files} |
There was a problem hiding this comment.
Please use the catkin_install_python macro to install python scripts. See http://docs.ros.org/kinetic/api/catkin/html/howto/format2/installing_python.html
|
When I tried without the init.py, the mycpplib.so is installed but can't be imported in Python. |
|
Sorry for the late response, looks good now :). Thanks again. |
After installing my package, I noticed that an init.py was missing and python was unable to import correctly.