Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend)::guitar:Adding notification || JIRA: PT-9 #7

Merged
merged 17 commits into from
May 12, 2022
Merged

Conversation

LeThanhPhongLTV
Copy link
Contributor

image
image
image

@LeThanhPhongLTV LeThanhPhongLTV requested review from lucwj and dzunglee May 11, 2022 08:35
@LeThanhPhongLTV LeThanhPhongLTV self-assigned this May 11, 2022
<div class="container mx-auto p-4 border-4 rounded-lg drop-shadow-sm">
<div class="font-bold pb-4">Mix and match</div>
<div class="grid grid-cols-5 gap-4 text-center drop-shadow">
<div class="border lg:col-span-1 md:col-span-2 sm:col-span-2">.col-lg-1 .col-md-2 .col-sm-2</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Các tên class đang chưa đúng em nhỉ?


<div class="border lg:col-span-1 md:col-span-2 sm:col-span-2">.col-lg-1 .col-md-2 .col-sm-2</div>
<div class="border">.col-1</div>
<div class="border lg:col-span-3 sm:col-span-2">.col-lg-3 .col-sm-2</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tới đây nữa: col-span-3

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dzunglee dzunglee merged commit c4c6813 into main May 12, 2022
@dzunglee dzunglee deleted the feat/PT-9 branch May 12, 2022 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants