Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tickects/PREOPS-5067: Add basis function and survey rewards timeline plots that do not use python callbacks #84

Merged
merged 15 commits into from
Apr 24, 2024

Conversation

ehneilsen
Copy link
Collaborator

Needed to support adding such plots to the Times Square pre-night briefing.

@rhiannonlynne
Copy link
Member

My look at this was entirely cursory, as most of the move from javascript to python callbacks is beyond what I'm familiar with.
As ever, I would prefer more comment lines to help understand why a particular piece of code is being used (why one version of the start date instead of another, for example).

@ehneilsen ehneilsen merged commit 92edb7b into main Apr 24, 2024
7 checks passed
@ehneilsen ehneilsen deleted the tickects/PREPOS-5067 branch April 24, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants