Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PREOPS-4934: Fix minor issues found during end-to-end testing. #72

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

alserene
Copy link
Collaborator

Changes addressing identified issues include:

  • Map heading now consistent across basis function selection by row selection or drop-down.
  • Upper bound of date range decreased by 0.01 MJD (~15 mins) to prevent error at upper bound.
  • Reset nside and colour palette to defaults when reset button clicked.

Additional aesthetic and code layout changes include:

  • Reset button moved up slightly to fill gap.
  • Hover description added to reset button and icon slightly increased in size.
  • Function called on button click moved out of layout code section.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 13.11%. Comparing base (393e6ec) to head (0196863).

Files Patch % Lines
...iew/app/scheduler_dashboard/scheduler_dashboard.py 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   13.13%   13.11%   -0.02%     
==========================================
  Files          43       43              
  Lines        3381     3385       +4     
  Branches      501      501              
==========================================
  Hits          444      444              
- Misses       2928     2932       +4     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ehneilsen ehneilsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@alserene alserene merged commit 470e267 into main Feb 27, 2024
7 of 9 checks passed
@alserene alserene deleted the tickets/PREOPS-4934 branch February 27, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants