-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PREOPS-4838 Limiting the datetime selector’s range to those for which there are sky brightness files #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like the right basic approach, but I worry about getting the date range at the global level, rather than inside a method or function. The SkyModelPre class is is slow to instantiate, particularly when the argument to limit the initial load window is not set to something really short, and putting this at the global level means that importing the module is slowed down by this, even when the class never actually needs to be instantiated.
…ther than globally as per Eric's comment
eea1302
to
304ec17
Compare
Thanks for the feedback @ehneilsen. I've wrapped the code in a function and rebased the branch |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
- Coverage 13.21% 13.15% -0.06%
==========================================
Files 43 43
Lines 3368 3375 +7
Branches 501 501
==========================================
- Hits 445 444 -1
- Misses 2914 2922 +8
Partials 9 9 ☔ View full report in Codecov by Sentry. |
@ehneilsen also fixed the tests |
Get the date range covered by SkyBrightness_Pre data files and limit date picker to this range so that user cannot select outside the values that have data