-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PREOPS-4832 Add a button to reset dashboard to initial load conditions #66
Conversation
@ehneilsen I'm not sure what is wrong with the tests. I guess it's something conda related. Can you please check and let me know what's happening? |
pytest just released version 8.0.0, which isn't backward compatible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, and does seem to reset the pickle, so it's good enough to merge, but I don't think it does all of what we want it to. In particular, even after the reset, it does not restore the original order of the basis functions in the tables of basis functions, if the user has previously reordered them. I think this is a manifestation of problem 1.3 in the user testing report. Whenever that fix is applied, we should make sure it covers the case of a pickle being reloaded as well.
@ehneilsen I've made the change to reset the basis function order whenever the file is reloaded. I also copied a change you made to |
There were also a couple of updates needed to make schedview compatible with the latest version of rubin_scheduler. I merged the PRs to make these fixes onto main this morning, so if you rebase it should fix the issue. |
332a744
to
42325fe
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
==========================================
- Coverage 13.24% 13.21% -0.04%
==========================================
Files 43 43
Lines 3360 3368 +8
Branches 500 501 +1
==========================================
Hits 445 445
- Misses 2906 2914 +8
Partials 9 9 ☔ View full report in Codecov by Sentry. |
Add a button to reload a pickle file to restore original loading condition