Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PREOPS-4817: Integrate key and map with colourblind-friendly plot elements. #63

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

alserene
Copy link
Collaborator

  • The static key has been removed.
  • The plot objects have had kwargs added that allow the objects to be displayed nicely in the plot's native key.
  • The order in which plot objects are added has been rearranged to display key objects in a nice order.
  • The layout around the plot has been modified to allow for the new plot-attached key.
  • Colours of plot line objects (ecliptic, galactic plane, etc.) have been modified for greater accessibility, with colours derived from a colourblind-accessible colour palette.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (3a3d717) 13.05% compared to head (bbf8fae) 13.10%.

Files Patch % Lines
schedview/plot/survey.py 0.00% 29 Missing ⚠️
...iew/app/scheduler_dashboard/scheduler_dashboard.py 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   13.05%   13.10%   +0.04%     
==========================================
  Files          42       42              
  Lines        3270     3258      -12     
  Branches      490      490              
==========================================
  Hits          427      427              
+ Misses       2834     2822      -12     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emanehab99
Copy link
Collaborator

Looks good! Thanks

Copy link
Collaborator

@ehneilsen ehneilsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@alserene alserene merged commit b4a9bb6 into main Jan 25, 2024
8 of 9 checks passed
@alserene alserene deleted the tickets/PREOPS-4817 branch January 25, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants