DM-52722: Allow for lsstcam_ci to build from rebuild #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roceb
force-pushed
the
tickets/DM-52722
branch
from
61fa990 to
ab60188
Compare
ktlim
reviewed
Nov 5, 2025
| -n pass "--no-fetch" parameter to lsst_build | ||
| -B pass "--no_binary-fetch" parameter as false to lsst_build | ||
| -B pass "--no-binary-fetch" parameter as false to lsst_build | ||
| -L download ci_lsstcam_testdata |
Contributor
There was a problem hiding this comment.
Spacing looks off. But since this is an internal argument used by Jenkins only, and no one else should have credentials to do it, I would not even mention it here (or I would say just that).
| NO_FETCH=false | ||
| NO_BINARY_FETCH=false | ||
| UPDATE=false | ||
| LSSTCAM_ONLY=false |
Contributor
There was a problem hiding this comment.
See PR in ci-scripts. It might be good to include the CI_ prefix here to make things clearer.
| ARGSBUILD=("--no-binary-fetch") | ||
| fi | ||
| if [[ $LSSTCAM_ONLY == true ]]; then | ||
| export LSSTCAM_TESTDATA_DIR=${LSSTCAM_TESTDATA_DIR:-'/tmp/LSSTCAMData'} |
Contributor
There was a problem hiding this comment.
If the whole purpose of this is to set an environment variable, I'm not understanding why it can't be set by the caller of rebuild (which is inserting the -L), meaning that no changes are needed at all to rebuild?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.