DM-52398: Implement findDataset using the new query system #1258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhirving
force-pushed
the
tickets/DM-52398
branch
from
d6ff6a1 to
50de665
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1258 +/- ##
==========================================
- Coverage 88.50% 88.34% -0.17%
==========================================
Files 382 382
Lines 51201 51213 +12
Branches 6118 6116 -2
==========================================
- Hits 45318 45242 -76
- Misses 4434 4524 +90
+ Partials 1449 1447 -2 ☔ View full report in Codecov by Sentry. |
dhirving
force-pushed
the
tickets/DM-52398
branch
from
a2aa6bb to
2bc74a5
Compare
dhirving
force-pushed
the
tickets/DM-52397
branch
from
6486e65 to
4c75410
Compare
dhirving
force-pushed
the
tickets/DM-52398
branch
5 times, most recently
from
e8ebe05 to
35ec7c2
Compare
dhirving
force-pushed
the
tickets/DM-52397
branch
from
4c75410 to
19a3020
Compare
Ahead of reworking its implementation, add a few tests to nail down the behavior of edge cases for findDataset.
It turns out that some downstream code (in pipe_tasks and possibly others) relies on undocumented behavior where dimension records will be preserved from the input data ID to the output ref.
dhirving
force-pushed
the
tickets/DM-52398
branch
from
35ec7c2 to
de2f93f
Compare
Fix an issue where attempting to query datasets with a timespan overlap constraint but no calibration collections in the search would cause the query builder to raise "sqlalchemy.exc.ArgumentError: Only '=', '!=', 'is_()', 'is_not()', 'is_distinct_from()', 'is_not_distinct_from()' operators can be used with None/True/False"
dhirving
force-pushed
the
tickets/DM-52398
branch
from
de2f93f to
c8830ea
Compare
Replace the implementation of Registry.findDataset with the new query system, to allow us to retire daf_relation.
dhirving
force-pushed
the
tickets/DM-52398
branch
from
c8830ea to
79c994b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the implementation of
Registry.findDataset()with the new query system, to allow us to retire daf_relation. This attempts to preserve the existing behavior, with one exception: returned DatasetRefs now havedataId.hasFull() = True, in line with the behavior of the new query system.Checklist
doc/changesconfigs/old_dimensions