-
Notifications
You must be signed in to change notification settings - Fork 0
OSW-943: Add e2e tests using playwright. #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3b7c566 to
f057e79
Compare
f6377e1 to
2f886c0
Compare
Vebop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me but I would prefer if Eman has time to review as well since she started looking into this before! Thanks for setting this all up !
emanehab99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @sebastian-aranda! I liked the gif/mp4 demo for getting the token. The docs is very comprehensive too.
There is only one typo to fix.
That would be a good base to extend our testing suite and run it in the CI. Maybe then we might need to move these tests to a separate directory as these won't run on the CI.
| /* global process */ | ||
| import { test, expect } from "@playwright/test"; | ||
|
|
||
| const NIGHTLY_DIGEST_URL = "https://base-lsp.lsst.codes/nightlydigest"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should point to usdf-dev?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch! Regarding moving the folder I added an exception parameter to dismiss these tests in the CI jobs 😉 .
4fc0009 to
7a40d4c
Compare
Focused on adding stress tests for load throughput assessment.
7a40d4c to
41d17f6
Compare
This PR add playwright configurations to run e2e (end-to-end) testing. These changes are particularly focused on stress testing to be able to assess on load into our different services by running different cases. Documentation about how to run tests is added as well.