Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-44635: Mobu in GitHub CI #3453

Merged
merged 5 commits into from
Jul 9, 2024
Merged

DM-44635: Mobu in GitHub CI #3453

merged 5 commits into from
Jul 9, 2024

Conversation

fajpunk
Copy link
Member

@fajpunk fajpunk commented Jun 24, 2024 •
edited
Loading

Testing

  • No github integrations enabled
  • Both integrations enabled
  • Only refresh integration enabled
  • Only CI integration enabled

@fajpunk fajpunk force-pushed the tickets/DM-44635/mobu-in-ci branch 13 times, most recently from 64346f5 to 37d6774 Compare June 25, 2024 19:49
@fajpunk fajpunk mentioned this pull request Jun 25, 2024
Merged
athornton
athornton approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@athornton athornton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor things. One is just a documentation thing that you will learn that Russ cares a lot about, and the other is a slight concern about collapsing the two configmaps into one.

@fajpunk fajpunk force-pushed the tickets/DM-44635/mobu-in-ci branch 3 times, most recently from 7e996b4 to be45c03 Compare June 28, 2024 19:29
@fajpunk fajpunk force-pushed the tickets/DM-44635/mobu-in-ci branch from c422846 to 47ccb0c Compare July 9, 2024 14:26
@fajpunk fajpunk force-pushed the tickets/DM-44635/mobu-in-ci branch from 47ccb0c to c2ae8b7 Compare July 9, 2024 14:26
@fajpunk fajpunk force-pushed the tickets/DM-44635/mobu-in-ci branch 2 times, most recently from c6e02db to f9fd36b Compare July 9, 2024 18:24
@fajpunk fajpunk enabled auto-merge July 9, 2024 18:24
@fajpunk fajpunk added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit d0b7f0a Jul 9, 2024
6 checks passed
@fajpunk fajpunk deleted the tickets/DM-44635/mobu-in-ci branch July 9, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athornton athornton athornton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fajpunk @athornton