tickets/DM-40289: enable nublado3 at T&S sites #2385
Conversation
athornton
force-pushed
the
tickets/DM-40289
branch
from
44a627b
to
32c5e7f
Compare
| singleuser: | ||
| extraAnnotations: | ||
| k8s.v1.cni.cncf.io/networks: "kube-system/dds" |
There was a problem hiding this comment.
Is this supposed to be an additional annotation to add to the created pod? If so, does this work? I feel like it couldn't work, since the Nublado controller is creating the pod and it doesn't know anything about this setting.
There was a problem hiding this comment.
Uh oh. Something like this is going to need to work, which may require adding a new config setting to the controller.
Yes, this is the magic annotation on the pod that causes it to couple to the correct multus-provided network. It is untested, because only T&S sites use this feature.
There was a problem hiding this comment.
OK, it we pass "annotations" into create_pod() it will do the right thing. Not sure if we've already got annotations in the pod config, but if not it's easy to add.
There was a problem hiding this comment.
Yeah, we'll have to add it as a config setting and then pipe it down through create_user_pod.
There was a problem hiding this comment.
There was a problem hiding this comment.
I think this is ready to go once extraAnnotations is moved into the lab controller configuration.
athornton
force-pushed
the
tickets/DM-40289
branch
3 times, most recently
from
5d4d019
to
eaf6ce0
Compare
athornton
force-pushed
the
tickets/DM-40289
branch
from
eaf6ce0
to
1294700
Compare
Reverse the sense of the old mobu configuration option disableSlackAlerts to be slackAlerts and enabled by default, since this works better with conditional secrets.
athornton
force-pushed
the
tickets/DM-40289
branch
from
1294700
to
5241f49
Compare
No description provided.