Skip to content

Commit

Permalink
Stop calculating v1 URL
Browse files Browse the repository at this point in the history
This was a holdover from Keeper v1 to maintain consistency in logging,
but overall its not safe to do this because the v1 APIs may not be
enabled for a given deployment.
  • Loading branch information
jonathansick committed Mar 24, 2022
1 parent 5f63c7d commit 3b070fa
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions keeper/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -884,15 +884,8 @@ def should_rebuild(self, build: Build) -> bool:
logger = get_logger(__name__)
logger.info("Inside Edition.should_rebuild")

# shim during refactoring
from keeper.api._urls import url_for_edition

logger = get_logger(__name__)

logger.info(
"Edition {!r} in should_rebuild".format(url_for_edition(self))
)

candidate_build = build

# Prefilter
Expand All @@ -907,8 +900,7 @@ def should_rebuild(self, build: Build) -> bool:

tracking_mode = edition_tracking_modes[self.default_mode_id]
logger.warning(
"Edition {!r} has an unknown tracking"
"mode".format(url_for_edition(self))
"Edition {!r} has an unknown tracking" "mode".format(self.slug)
)

return tracking_mode.should_update(self, candidate_build)
Expand Down

0 comments on commit 3b070fa

Please sign in to comment.