Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45211: Update shared dataset policies #692

Merged
merged 1 commit into from
Oct 9, 2024
Merged

DM-45211: Update shared dataset policies #692

merged 1 commit into from
Oct 9, 2024

Conversation

taranu
Copy link
Contributor

@taranu taranu commented Aug 27, 2024

No description provided.

usdf/datasets.rst Outdated Show resolved Hide resolved
usdf/datasets.rst Show resolved Hide resolved

All newly-added datasets, including external datasets, must follow the guidelines for supplying a :ref:`README <readme_guidelines_usdf>` file. Updates to the readme should be reviewed on subsequent Jira tickets.

Requests for new shared directories for should be sent to Kian-Tat Lim. Users are often given ownership of the shared directory and are responsible for setting appropriate permissions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Requests for new shared directories for should be sent to Kian-Tat Lim. Users are often given ownership of the shared directory and are responsible for setting appropriate permissions.
Requests for new shared directories for should be sent to ``#ops-usdf-data-curation`` in the Rubin Observatory Slack. Members of the ``rubinmgr`` group will handle these, including having quotas applied. Requesting users are often given initial ownership of the shared directory and are responsible for setting appropriate permissions. If the shared dataset needs central curation, ownership may be set to ``rubinmgr`` after it is initially populated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you going to create that channel? I don't see it listed, unless it's private.


Policy
======
New shared datasets should be added to ``/shared``, following policies to be detailed in `DM-31704 <https://rubinobs.atlassian.net/browse/DM-31704>`_. Additions or modifications to any dataset that is to be used in regular (re-)processing must have a corresponding RFC. The RFC should contain information about:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not exactly clear from this whether new shared datasets need an RFC. We should say what the current status is, even if the policy is up in the air. If we do require an RFC, then we should make clear that the request for space allocation below is after the RFC has been adopted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the new line. I figure anything getting ingested must have an RFC, and anything being used for regular processing but not in any butler (I'm not sure what that would be, but maybe some camera/summit stuff?) ought to be too. Anything else I suppose doesn't need an RFC, although I'm not sure what the leaves. I guess common git repos like testdata_*?

usdf/datasets.rst Show resolved Hide resolved
@@ -77,67 +93,19 @@ Here is a template for what each refcat's readme should contain:
The configuration that was used to ingest the data is included in this
directory as `IngestIndexedReferenceTask.py`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can actually do something like the immutability/sharing below, as long as the modification access is coming from the interactive or batch nodes (not Kubernetes/notebooks). But we can put that back in when it's better-defined.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that basically what's described with setting permissions above?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing ownership is kind of a brute-force means of doing this; we can do something a bit more sophisticated for "temporary unlock to allow modification" or even "permanently allow curation by this group of people other than rubinmgr".


All newly-added datasets, including external datasets, must follow the guidelines for supplying a :ref:`README <readme_guidelines_usdf>` file. Updates to the readme should be reviewed on subsequent Jira tickets.

Requests for new shared directories for should be sent to ``#ops-usdf-data-curation`` in the Rubin Observatory Slack (lsstc).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just make this usdf-help@slac.stanford.edu for now.


All newly-added datasets, including external datasets, must follow the guidelines for supplying a :ref:`README <readme_guidelines_usdf>` file. Updates to the readme should be reviewed on subsequent Jira tickets.

Requests for new shared directories for should be emailed to ``usdf-help@slac.stanford.edu``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Requests for new shared directories for should be emailed to ``usdf-help@slac.stanford.edu``.
Requests for new shared directories should be emailed to ``usdf-help@slac.stanford.edu``.

@taranu taranu force-pushed the tickets/DM-45211 branch 2 times, most recently from 4e58a83 to 3a80a2a Compare October 9, 2024 00:46
@taranu taranu merged commit 0ea9487 into main Oct 9, 2024
3 checks passed
@taranu taranu deleted the tickets/DM-45211 branch October 9, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants