Set current DPI scale for HDPI monitors #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lslm
force-pushed
the
ls/fix-dpi-scaling
branch
2 times, most recently
from
6008831
to
46dd268
Compare
This might not be the best solution, but I will use it to make the UI elements looks better in HDPI monitors like MacBooks' Retina Display
lslm
force-pushed
the
ls/fix-dpi-scaling
branch
from
46dd268
to
122447a
Compare
This implementation follows @rokups approach: ocornut/imgui#1786 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Current Dear ImGui does not have a canonical solution to handle adaptive DPI for multiple monitors.
Proposed solution
I decided to use the
glfwGetWindowContentScale(window, &xScale, &yScale)function to get the monitor scale and set the values ofxScaleandyScaleinto theio.DisplayFramebufferScale.This might not be the best solution, but I will use it to make the UI elements look better in HDPI monitors like MacBooks' Retina Display.
References
ocornut/imgui#1786
ocornut/imgui#1676
Why retina screen coordinate value is twice the value of pixel value
How should I handle DPI in my application?
ocornut/imgui#1786 (comment)