Update deprecated functions #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxong
suggested changes
May 26, 2017
| { | ||
| char * addr = inet_ntoa (* (struct in_addr *) & address -> host); | ||
| char buff[16]; | ||
| const char * addr = InetNtop(AF_INET, (struct in_addr *)&address->host, buff, sizeof(buff)); |
There was a problem hiding this comment.
InetNtop is only available in Vista and later: https://msdn.microsoft.com/en-us/library/windows/desktop/cc805843(v=vs.85).aspx
There was a problem hiding this comment.
2024 calling. I don't think that Windows XP support and older is any kind of argument anymore, so this could probably be moved forward one away or another.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.