Skip to content

Conversation

@ufukygmr
Copy link
Contributor

@ufukygmr ufukygmr commented Feb 3, 2025

What?

Closes #35

This PR initializes the AtlasML Python project by setting up its foundational structure, including FastAPI routing, an ML module, and standalone script execution for machine learning.

Why?

This setup ensures that:

The ML module (ml) can be run independently for development.
The FastAPI-based microservice structure is modular and scalable.
Environment variables can be easily configured via os.getenv().
Documentation is updated with instructions for both standalone and API-based usage.

How?

Key Changes:

  • Updated app.py:

    • Introduced ENV = os.getenv("ENV", "dev") for environment-based configurations.
    • Included the FastAPI router from atlasml.routers.health_router.
    • Removed the hardcoded /health endpoint, moving it to a separate module.
  • Created ml/ module:

    • ml_runner.py: A standalone script to execute the ML model independently.
    • model.py: Contains a mock ML handler function (ml_model_handler()) for model execution.
    • init.py: Makes the module importable.
  • Refactored API Routing:

    • routers/health.py: Moved the /health endpoint here.
    • routers/init.py: Imports health_router for modularity.
    • Updated app.py to include health_router.
  • Updated Documentation (README.md):

    • Added instructions for running the ML module independently:
      bash
      Copy
      Edit
      python atlasml/ml/ml_runner.py
      Maintained API instructions for running with FastAPI and Uvicorn.

Affected Issues & Feature Proposal

Checklist

General

AtlasML - Machine Learning

  • I updated the machine learning documentation.

Testing

Testing Instructions

Requirements:

  • At least 3 Competencies with no Relations
  • ...

Steps:

  1. ...
  2. ...

Review Progress

Code Review
  • Code Review 1
  • Code Review 2
Manuel Test
  • Test 1
  • Test 2

@ufukygmr ufukygmr added the documentation Improvements or additions to documentation label Feb 3, 2025
@ufukygmr ufukygmr self-assigned this Feb 3, 2025
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Feb 3, 2025
@ufukygmr ufukygmr changed the title Development: update folder structure and add ml folder Development: Finalise Folder Structure Feb 3, 2025
Copy link
Contributor

@ardakaraman0 ardakaraman0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions
Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 11, 2025
@MaximilianAnzinger MaximilianAnzinger added this to the 0.0.0 milestone Feb 11, 2025
@MaximilianAnzinger MaximilianAnzinger merged commit cbd37e4 into main Feb 11, 2025
6 of 8 checks passed
@MaximilianAnzinger MaximilianAnzinger deleted the feature/General/final-folder-structure branch February 11, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

AtlasML: Finalise Folder structure

4 participants