Skip to content

Conversation

@MaximilianAnzinger
Copy link
Collaborator

No description provided.

@ardakaraman0
Copy link
Contributor

Also as an open thread, would we be interested in a template for the Pull Request where on the down bottom there can be a section where
"As the reviewer I have, [ ] checked the ticket description, [ ] checked whether the code is written following the rules, [ ] tested on [ ] Google Chrome, [ ] Safari, etc, ....."
and bunch of check items (tick boxes) for the reviewer to check off?

@github-actions
Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@ufukygmr
Copy link
Contributor

ufukygmr commented Dec 1, 2024

Also as an open thread, would we be interested in a template for the Pull Request where on the down bottom there can be a section where "As the reviewer I have, [ ] checked the ticket description, [ ] checked whether the code is written following the rules, [ ] tested on [ ] Google Chrome, [ ] Safari, etc, ....." and bunch of check items (tick boxes) for the reviewer to check off?

I would like to avoid at all. Since we will be writing a microservice, what they mostly do will be go over the code andrunning the microservice - testing the endpoints etc. So, I don't think we will intense review processes for a while. WE can skip this part for now. I think this will be needed when Atlas migration started.

Copy link
Contributor

@ufukygmr ufukygmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good for me.

@github-actions github-actions bot removed the stale label Dec 2, 2024
Copy link
Contributor

@ufukygmr ufukygmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought 2 things regarding the templates.

@MaximilianAnzinger MaximilianAnzinger merged commit 66784a4 into main Dec 3, 2024
4 checks passed
@MaximilianAnzinger MaximilianAnzinger deleted the chore/pr-and-issue-templates branch December 3, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants