Improvements to etable
#473
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In `build_tex_png`, `*.png` is detected, use that as `png_name` and then remove from `export` - Needed to move `export_path` creation below to ensure this works
This one is a bit complicated as it happens only when `export` is used, the image is built in `tempdir()`, *and* the directory does not exist. `check_set_path` returns either relative or absolute path: - If `etable` has to make the directory, then relative path. - If it doesn't then, then absolute path. This creates problems when you `setwd(tempdir())` to build the image because `file.copy` copies into the tempdir when using a relative path
- `knitr::fig_path('.png')` creates a file in the Rmarkdown output directory. This is really useful since it can be processed with `self_contained`, for example
- Additinally, knitr has `output.dir` option to, so this outputs into the correct output dir correctly. For example when using `quarto` with `execute-dir`, the output dir and the execute dir can differ.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Laurent,
This PR has a set of commits to (potentially) improve
etable. Here's the set of changes:div.classis an option forsetFixest_etableto matchmarkdown.etable(..., file = path)fails whenpathhas a directory that doesn't exist. This PR checks for this and creates the directory if needed.Fix a sort of nefarious bug with
export. Say you haveetable(..., export = path)wherepathis a relative directory, the directory does not exist, andmarkdown = FALSE. The functioncheck_set_pathwill return the relative path back. However, building the png sets the working directory totempdir(), so moving the png topathfails.Allowing for named exports How do you name the PNG file that etable exports? #451
To do this, the file name is extracted if it exists (and with the fix to 3) and used as
png_name.The controversial change involves
markdownprocessing. I can remove this one if you don't agree.Rmarkdown and quarto (both using knitr) saves
plots inknitr::fig_path()(usuallyX_files/figures-html/). Putting the etable pngs in here gives the benefit of allowingself_containedto process them.Quarto/
knitrhas the optionoutput.dirwhich lets your execution working directory differ from where the output is created. You can access this withknitr::opts_knit$get("output.dir"). This means with this option, the images produced byetablewon't be in the correct location of thehtmldocument.For example, if I have a .Rmd in a subfolder (e.g.
./vignettes/) but I want it use the main folder (./) as the working directory,etablewill use./etable/images/instead of./vignettes/etable/images.By using these two functions, I think etable much better ties in with quarto/rmarkdown. I've faced this problem with my own day-to-day use of qmd, so it's not just a random edge case (or maybe I'm the edge case).