fix ide issues (ankidroid#15042)

* ide issue in CardTemplatePreviewer
* ide issue in CollectionManager
* ide issue in CustomMaterialTapTargetPromptBuilder
* ide issue in DeckSpinnerSelection
* ide issue in Preferences
* ide issue in MediaRegistration
* ide issue in SharedDecksActivity
* ide issue in StudyOptionsActivity
* ide issue in Whiteboard

AnkiDroid/src/main/java/com/ichi2/anki/CardTemplatePreviewer.kt

@@ -120,7 +120,8 @@ open class CardTemplatePreviewer : AbstractFlashcardViewer() {
         finishWithAnimation(ActivityTransitionAnimation.Direction.END)
     }
 
-    @Suppress("DEPRECATION", "Deprecated in API34+dependencies for predictive back feature")
+    @Deprecated("Deprecated in Java")
+    @Suppress("Deprecated in API34+dependencies for predictive back feature")
     override fun onBackPressed() {
         Timber.i("CardTemplatePreviewer:: onBackPressed()")
         super.onBackPressed()
@@ -392,14 +393,11 @@ open class CardTemplatePreviewer : AbstractFlashcardViewer() {
     }
 
     /** Override certain aspects of Card behavior so we may display unsaved data  */
-    inner class PreviewerCard : Card {
-        private val mNote: Note?
+    inner class PreviewerCard(col: Collection, id: Long) : Card(col, id) {
+        private val mNote: Note? = null
 
-        constructor(col: Collection, id: Long) : super(col, id) {
-            mNote = null
-        }
-
-        /* if we have an unsaved note saved, use it instead of a collection lookup */ override fun note(
+        /* if we have an unsaved note saved, use it instead of a collection lookup */
+        override fun note(
             reload: Boolean
         ): Note {
             return mNote ?: super.note(reload)

AnkiDroid/src/main/java/com/ichi2/anki/CollectionManager.kt

@@ -149,7 +149,7 @@ object CollectionManager {
         }
 
     fun compareAnswer(expected: String, given: String): String {
-        // bypass the lock, as the type answer code is heavily nested in non-suspend funs
+        // bypass the lock, as the type answer code is heavily nested in non-suspend functions
         return getBackend().compareAnswer(expected, given)
     }
 

AnkiDroid/src/main/java/com/ichi2/anki/CustomMaterialTapTargetPromptBuilder.kt

@@ -27,9 +27,9 @@ import uk.co.samuelwall.materialtaptargetprompt.extras.backgrounds.RectangleProm
 import uk.co.samuelwall.materialtaptargetprompt.extras.focals.CirclePromptFocal
 import uk.co.samuelwall.materialtaptargetprompt.extras.focals.RectanglePromptFocal
 
-class CustomMaterialTapTargetPromptBuilder<T>(val activity: Activity, val featureIdentifier: T) : MaterialTapTargetPrompt.Builder(activity) where T : Enum<T>, T : OnboardingFlag {
+class CustomMaterialTapTargetPromptBuilder<T>(val activity: Activity, private val featureIdentifier: T) : MaterialTapTargetPrompt.Builder(activity) where T : Enum<T>, T : OnboardingFlag {
 
-    fun createRectangle(): CustomMaterialTapTargetPromptBuilder<T> {
+    private fun createRectangle(): CustomMaterialTapTargetPromptBuilder<T> {
         promptFocal = RectanglePromptFocal()
         return this
     }

AnkiDroid/src/main/java/com/ichi2/anki/DeckSpinnerSelection.kt

@@ -62,8 +62,7 @@ class DeckSpinnerSelection(
 
     private val mFragmentManagerSupplier: FragmentManagerSupplier = context.asFragmentManagerSupplier()
 
-    lateinit var dropDownDecks: List<DeckNameId>
-        private set
+    private lateinit var dropDownDecks: List<DeckNameId>
     private var mDeckDropDownAdapter: DeckDropDownAdapter? = null
 
     fun initializeActionBarDeckSpinner(actionBar: ActionBar) {
@@ -116,7 +115,7 @@ class DeckSpinnerSelection(
         return collection.decks.allNamesAndIds(includeFiltered = includeFiltered)
     }
 
-    fun setSpinnerListener() {
+    private fun setSpinnerListener() {
         spinner.setOnTouchListener { _: View?, motionEvent: MotionEvent ->
             if (motionEvent.action == MotionEvent.ACTION_UP) {
                 displayDeckSelectionDialog(collection)

AnkiDroid/src/main/java/com/ichi2/anki/MediaRegistration.kt

@@ -177,7 +177,7 @@ class MediaRegistration(private val context: Context) {
     companion object {
         private const val MEDIA_MAX_SIZE = 5 * 1000 * 1000
         private const val COLOR_GREY = 0
-        const val COLOR_TRUE = 2
+        private const val COLOR_TRUE = 2
         private const val COLOR_INDEX = 3
         private const val COLOR_GREY_ALPHA = 4
         private const val COLOR_TRUE_ALPHA = 6

AnkiDroid/src/main/java/com/ichi2/anki/SharedDecksActivity.kt

@@ -150,6 +150,7 @@ class SharedDecksActivity : AnkiActivity() {
      * If user can go back in WebView, navigate to previous webpage.
      * Otherwise, close the WebView.
      */
+    @Deprecated("Deprecated in Java")
     @Suppress("deprecation") // onBackPressed
     override fun onBackPressed() {
         when {

AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsActivity.kt

@@ -73,6 +73,7 @@ class StudyOptionsActivity : NavigationDrawerActivity(), StudyOptionsListener, C
         finishWithAnimation(ActivityTransitionAnimation.Direction.END)
     }
 
+    @Deprecated("Deprecated in Java")
     override fun onBackPressed() {
         if (isDrawerOpen) {
             super.onBackPressed()

AnkiDroid/src/main/java/com/ichi2/anki/Whiteboard.kt

@@ -75,7 +75,7 @@ class Whiteboard(activity: AnkiActivity, handleMultiTouch: Boolean, inverted: Bo
     private val mColorPalette: LinearLayout
     private val mHandleMultiTouch: Boolean = handleMultiTouch
     private var mOnPaintColorChangeListener: OnPaintColorChangeListener? = null
-    val currentStrokeWidth: Int
+    private val currentStrokeWidth: Int
         get() = mAnkiActivity.sharedPrefs().getInt("whiteBoardStrokeWidth", 6)
 
     override fun onDraw(canvas: Canvas) {

AnkiDroid/src/main/java/com/ichi2/anki/preferences/Preferences.kt

@@ -43,7 +43,6 @@ import com.ichi2.libanki.utils.TimeManager
 import com.ichi2.themes.setTransparentStatusBar
 import com.ichi2.utils.getInstanceFromClassName
 import timber.log.Timber
-import java.util.*
 import kotlin.reflect.jvm.jvmName
 
 class Preferences :