forked from kubernetes/minikube
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
support componentconfigs with native type aliases
Some componentconfig options are aliased to native convertible types (e.g. ProxyMode) but FindAndSet() was unable to detect that and so it wasn't possible to set these values via `--extra-config`. This change addresses that by using the reflected value's Kind instead of a type assertion on its interface. It's also worth noting that any value with the type Duration (e.g. proxy.IPTablesSyncPeriod) is also unable to be set for the same reason, but this commit does not address that. See kubernetes#1217
- Loading branch information
Showing
2 changed files
with
28 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters