Skip to content

Commit

Permalink
Removed unnecessary tilt, obstruction and hold characteristics in the…
Browse files Browse the repository at this point in the history
… window-covering
  • Loading branch information
lprhodes committed Apr 20, 2017
1 parent 6345337 commit fa46433
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 37 deletions.
72 changes: 36 additions & 36 deletions accessories/windowCovering.js
Original file line number Diff line number Diff line change
Expand Up @@ -227,42 +227,42 @@ class WindowCoveringAccessory extends BroadlinkRMAccessory {
defaultValue: Characteristic.PositionState.STOPPED
});

this.createToggleCharacteristic({
service,
characteristicType: Characteristic.CurrentHorizontalTiltAngle,
propertyName: 'currentHorizontalTiltAngle',
});

this.createToggleCharacteristic({
service,
characteristicType: Characteristic.CurrentVerticalTiltAngle,
propertyName: 'currentVerticalTiltAngle',
});

this.createToggleCharacteristic({
service,
characteristicType: Characteristic.TargetHorizontalTiltAngle,
propertyName: 'targetHorizontalTiltAngle',
});

this.createToggleCharacteristic({
service,
characteristicType: Characteristic.TargetVerticalTiltAngle,
propertyName: 'targetVerticalTiltAngle',
});

this.createToggleCharacteristic({
service,
characteristicType: Characteristic.HoldPosition,
propertyName: 'holdPosition',
});

this.createToggleCharacteristic({
service,
characteristicType: Characteristic.ObstructionDetected,
propertyName: 'obstructionDetected',
defaultValue: false
});
// this.createToggleCharacteristic({
// service,
// characteristicType: Characteristic.CurrentHorizontalTiltAngle,
// propertyName: 'currentHorizontalTiltAngle',
// });
//
// this.createToggleCharacteristic({
// service,
// characteristicType: Characteristic.CurrentVerticalTiltAngle,
// propertyName: 'currentVerticalTiltAngle',
// });
//
// this.createToggleCharacteristic({
// service,
// characteristicType: Characteristic.TargetHorizontalTiltAngle,
// propertyName: 'targetHorizontalTiltAngle',
// });
//
// this.createToggleCharacteristic({
// service,
// characteristicType: Characteristic.TargetVerticalTiltAngle,
// propertyName: 'targetVerticalTiltAngle',
// });
//
// this.createToggleCharacteristic({
// service,
// characteristicType: Characteristic.HoldPosition,
// propertyName: 'holdPosition',
// });
//
// this.createToggleCharacteristic({
// service,
// characteristicType: Characteristic.ObstructionDetected,
// propertyName: 'obstructionDetected',
// defaultValue: false
// });

this.windowCoveringService = service;

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "homebridge-broadlink-rm",
"version": "1.4.0",
"version": "1.4.1",
"description": "Broadlink RM plugin (including the mini and pro) for homebridge: https://github.com/nfarina/homebridge",
"license": "ISC",
"keywords": [
Expand Down

0 comments on commit fa46433

Please sign in to comment.