Migrate JavaScript FFI dependencies to node:sqlite#28
Conversation
lpil
left a comment
There was a problem hiding this comment.
Brilliant, thank you!
Could you rebase on main and update the code to remove the use of private FFI APIs please 🙏
52c616f to
ab22d2e
Compare
|
@lpil |
|
Is this ready for a review? If so, please press the "ready for review" button and tag me 🙏 |
|
@lpil |
|
@lpil |
lpil
left a comment
There was a problem hiding this comment.
Thank you!! Looking great! I've left some small notes inline. We'll also need to update the Gleam version on CI.
Because this is a breaking change, it can only run on Node.js v22.5 or Deno v2.2 and later.
…sses to use the JS FFI format
3c3c09e to
cddee76
Compare
|
@lpil |
Changing the library used for JavaScript FFI to
node:sqlite.With this change, sqlight will be compatible with both Deno and Node.js.
This library relies on a fix merged in Deno v2.6.4, so you must use Deno version 2.6.4 or higher when running it.
Additionally, since Node.js is now a supported runtime, I have added commands to GitHub Actions to execute tests using Node.js.
close #21