Use type instead of sql_type

[allenwq]

• Support simple_form 3.3

Simple form updated their find_attribute_column in 3.3, sql_type is not work anymore.

def find_attribute_column(attribute_name)
  if @object.respond_to?(:type_for_attribute) && @object.has_attribute?(attribute_name)
    @object.type_for_attribute(attribute_name)
  elsif @object.respond_to?(:column_for_attribute) && @object.has_attribute?(attribute_name)
    @object.column_for_attribute(attribute_name)
  end
end

Actually, I don't know why sql_type is used before, @lowjoel Any comments ?

[allenwq]

@lowjoel Think all specs cannot run after rails or rspec update, something to do with the spec setup, can you help with that ?

[lowjoel]

@allenwq rebase on master.

This is because the Types API is only introduced in Rails 4.2. You'd need to check for the proper attribute and used that instead.

[allenwq]

@lowjoel Thanks ! Updated and slightly modified the specs.

[lowjoel]

If there are only 2 alternatives, maybe both should be tested as separate contexts?

[allenwq]

I have thought about that, it will duplicate the entire file and testing the same thing... finally I chose to use sample. What do you think ?

[lowjoel]

[:type, :sql_type].each do |method|
  # specs here
end

[allenwq]

Not that simple because DateTimeModel need to call the right method type or sql_type.

Think I have a way, will update first.

[allenwq]

@lowjoel Updated

[allenwq]

@lowjoel Any comments ?

[lowjoel]

Looks good.

[allenwq]

@lowjoel Thanks ! Can release a new version ?

[lowjoel]

Released.

[allenwq]

Thanks !